Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/name el gr #1415

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

gvrettos
Copy link
Contributor

Copy link

what-the-diff bot commented Oct 31, 2024

PR Summary

  • Enhancement of Test Features
    Imported JUnit 5 annotations (@AfterAll, @BeforeAll, @Nested) to improve the structuring and execution of test cases.

  • New Nested Test Class
    Introduced NameInGreekTest, a new nested test class to check the correctness of Greek name generation functionality.

  • Preparation and Cleanup for Test Class
    Implemented setup (@BeforeAll) and teardown (@AfterAll) methods that prepare and clean up after each test run in the NameInGreekTest class.

  • Expansion of Test Coverage
    Added multiple tests in NameInGreekTest class to ensure comprehensive validation. These tests include:

    • testName: Verifies if the full name format meets the standards.
    • testFullName: Runs testName.
    • testFirstName: Checks if the first name format is correct.
    • testFemaleFirstName: Tests the correctness of female first names across multiple repetitions.
    • testMaleFirstName: Tests the correctness of male first names across multiple repetitions.
    • testPrefix: Checks if the prefix format is as expected.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (d00cb0d) to head (6d61506).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1415      +/-   ##
============================================
+ Coverage     92.17%   92.34%   +0.16%     
- Complexity     3148     3154       +6     
============================================
  Files           319      319              
  Lines          6149     6149              
  Branches        591      591              
============================================
+ Hits           5668     5678      +10     
+ Misses          335      331       -4     
+ Partials        146      140       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit 089f7ad into datafaker-net:main Oct 31, 2024
12 checks passed
@gvrettos gvrettos deleted the feature/name-el_GR branch October 31, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants