-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add italian id number generator #1450
Conversation
PR Summary
|
2ad6412
to
22bc8fd
Compare
7317b8d
to
c6cb512
Compare
static boolean isConsonant(char c) { | ||
return Arrays.binarySearch(VOWELS, c) < 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually faster than using a List
(List.of
) and .contains()
?
Or Set...since Set is unique elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingthorin Thanks, fixed. Now using Set
.
c6cb512
to
46f0c04
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
============================================
+ Coverage 92.22% 92.30% +0.07%
- Complexity 3175 3199 +24
============================================
Files 321 323 +2
Lines 6198 6274 +76
Branches 593 595 +2
============================================
+ Hits 5716 5791 +75
- Misses 339 340 +1
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
No description provided.