-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argentina zipcodes #1453
Add argentina zipcodes #1453
Conversation
include ISO code for province with zip code
PR Summary
|
@@ -8,7 +8,30 @@ es-AR: | |||
street_suffix: [Avenida, Avda., Camino, Pasaje, Paseo] | |||
secondary_address: ['Esc. #', 'Puerta blanca', 'Porton verde', 'Reja negra', 'Pasillo al fondo', 'frente', 'piso #, depto. A'] | |||
# Though these are US-specific, they are here (in the default locale) for backwards compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR perhaps, but is this comment still relevant? If so, I don't get it :)
Thanks @Jonathan-Zollinger , PR looks great, happy to merge it once the build is done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
============================================
- Coverage 92.31% 92.30% -0.02%
Complexity 3199 3199
============================================
Files 323 323
Lines 6274 6274
Branches 595 595
============================================
- Hits 5792 5791 -1
- Misses 339 340 +1
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jonathan-Zollinger @bodiam Things like postcode:
should be located in file _AR.yml
, not es_AR.yml
. Postcodes are country-specific and don't depend on language.
In other words, postcodes would be the same for new Locale("es", "AR")
and new Locale("en", "AR")
.
that makes sense. I can move those changes and update the tests |
Overview
replaces the current 4-digit generator with an exhaustive list of argentine zip codes. I also noted that
es-AR
wasn't included in the list of locales in the README, so I added it there.Points to consider
Argentine zip codes preface 4 digits with an iso code as a single letter (ie
A####
). This PR includes the appropriate iso code with the zip code such that each zip code provided is an actual zip code used in argentina. These can be found at https://postalcodes.azinfoportal.com/argentina/Test coverage
I added a new test which iterates through all 4025 new zip codes and validates that they're all formatted with an expected letter followed by 4 digits. I'm not sure how much more to test than that.
calling
./mvnw clean install
from root runs w/ no errors.