Update maxRank to workaround limit on number of arguments of function
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagadbm
reviewed
Jul 31, 2024
| @@ -205,15 +205,37 @@ function addBorderNode(g, prefix, rank, order) { | |||
| return addDummyNode(g, "border", node, prefix); | |||
| } | |||
|
|
|||
| function splitToChunks(array, chunkSize = CHUNKING_THRESHOLD) { | |||
There was a problem hiding this comment.
just for readibility i would move these functions after maxRank
applyWithChunking first, followed by splitToChunks.
since we are not using const myFn = () => {} we can get away with this and makes it easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/datafold/issue/MON-3685/max-call-stack-on-large-lineage-graph#comment-20741a00
Math.max()