Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cement Framework Logging to file config needed #593

Open
c-w-m opened this issue Dec 4, 2020 · 1 comment
Open

Cement Framework Logging to file config needed #593

c-w-m opened this issue Dec 4, 2020 · 1 comment

Comments

@c-w-m
Copy link

c-w-m commented Dec 4, 2020

New Feature: add log to file for Cement Framework minimal_logger. This is typically only used in development so the implementation can be very simple (i.e., environment variable much like the use of CEMENT_FRAMEWORK_LOGGING).

Suggestions:
os.environ.set('CEMENT_LOGFILE') and then consume this in the misc.py class MinimalLogger(object).init to setup the log for both console and (optional) file logging.

Open to different approach, I just couldn't figure out how to wire this up via the existing config approach.
For example, an option to log.colorlog that would include the Cement Framework log entries to file so both the application and the framework log is combined.

Thanks,
cm

@c-w-m c-w-m changed the title Cement Logging to file needed Cement Framework Logging to file config needed Dec 4, 2020
@derks
Copy link
Member

derks commented Feb 3, 2021

Adding a CEMENT_FRAMEWORK_LOG_FILE makes complete sense, surprised nobody else has requested it. Usually I'm the only one digging into framework logs. ;)

Will add in 3.0.6 as long as there are no compat issues (shouldn't be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants