Refactor MinimalLogger / Disable by Default

[derks]

The minimal logger is documented in multiple places as the "framework logger" and "should only be used by the framework". This is also one of the few places where a hardcoded look for --debug is. I want to disable framework logging by default, and remove the look for --debug... as this should really only be used by core and extensions and should only log DEBUG... backward compatibility should not be an issue.

1. Set App.meta.framework_logging = False
2. Support additional variables:
   • CEMENT_LOG - Enabled/disabled (1 = 'enabled', disabled by default)
   • CEMENT_LOG_LEVEL - Logging level (INFO by default)
   • CEMENT_LOG_FILE - Path to log file (None by default)
   • CEMENT_LOG_CONSOLE - Enabled/disabled (1 = 'enabled', default)

Related:

• issue/593

Notes:

• Need to maintain CEMENT_FRAMEWORK_LOGGING for backward-compat.

[derks]

Triggering Cement logging based on --debug is deprecated in 3.0.8, and will be removed in 3.2.0. This will be documented at:

• https://docs.builtoncement.com/release-information/deprecations#3.0.8-2

[TomFreudenberg]

Hi @derks

just to get in touch here with you, I do not understand your idea.

Let's try to state something out:

a. You want to make logging configurable
b. You want to support framework logging and app logging
c. You want to make logging debug or quite or whatever
d. You want to allow "higher" logger like colorlog

My question is why you want to want to differ between framework and app logging

Isn't it that you want debug level overall if you you need?

For my opinion the framework should be suggested as being stable - So for an app developer it is not a point to LOG something from framework in anyway.

But if the framework decide to print some debug logs it has to be noticed by the app developer as well.

Saying that I think, that the number of LOG output from framewrk should be very rare. But if they are set, they should appear in any way.

So if one enables DEBUG, it should printout also the framework logs. And if I configure a special logger, I want to have all logs catched by it.

So for that, I would prefer to only log via app.log and only if set. If someone does not set a logger, than ther should be no log.

My 2 cents on that