Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Support of Hardcoded Debug Option to Trigger Cement Log #640

Open
derks opened this issue Jul 5, 2022 · 0 comments
Open

Remove Support of Hardcoded Debug Option to Trigger Cement Log #640

derks opened this issue Jul 5, 2022 · 0 comments
Labels
backward-incompatible
Milestone
3.2.0 Stable

Comments

@derks
Copy link
Member

derks commented Jul 5, 2022 •
edited
Loading

In Cement 3.0.8, the quiet/debug options were made configurable... however the utils.misc.MinimalLogger still looks for --debug in sys.argv, which is deprecated. The look at sys.argv needs to be removed in 3.2.0, additionally the usage of App.Meta.framework_logging needs to be refactored or removed as this was used to control whether framework logging is triggered (when --debug was passed).

Deprecation ID: 3.0.8-2

Ref:
@derks derks added this to the 3.2.0 Stable milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backward-incompatible
Projects
None yet
Milestone
3.2.0 Stable
Development

No branches or pull requests
1 participant
@derks