Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated imp usage (#386) #656

Merged
merged 4 commits into from
Dec 26, 2023
Merged

fix deprecated imp usage (#386) #656

merged 4 commits into from
Dec 26, 2023

Conversation

sigma67
Copy link
Contributor

@sigma67 sigma67 commented Oct 25, 2023

NOTICE: Prior to submitting a pull request, please ensure you abide by the
Guidelines for Code Contributions, including but not limited to:

  • PR is associated with at least one issue
  • Submit from a topic branch, not a pre-existing Cement branch
  • Make every effort to comply with PEP8
  • All tests pass successfully
  • Coverage reports 100% code coverage

Issue: #386

@sigma67
Copy link
Contributor Author

sigma67 commented Oct 26, 2023

Hi @derks, it seems the tests are passing except for some unrelated failures.

We also released this version internally and tested with our cement app under 3.12 and everything is working as expected.

@jonlowrey
Copy link

Hello @sigma67 and @derks,

Is there a scheduled release date for this fix?

I'm running into issues with the above mentioned aws-elasticbenastalk package via the aws-elastic-beanstalk-cli which we use for our deployment. Downgrading to 3.11 does fix my issue in the short term.

Thank you both for maintaining critical infrastructure.

@sigma67
Copy link
Contributor Author

sigma67 commented Nov 14, 2023

I haven't heard anything from @derks in a while. We've released the package internally with the fix and it's working fine for us.

For release use make dist and make dist-upload and adjust for your own package server (after adjusting the version in the source)

@derks
Copy link
Member

derks commented Nov 14, 2023

Thank you all for the feedback and effort in the PR. Due to starting a new job a few months ago I've been distracting and apologize for missing this. As the PR is tested and in use I'll look at this ASAP.

@sigma67
Copy link
Contributor Author

sigma67 commented Dec 22, 2023

Hi @derks, I have noticed an issue with my implementation that was causing DeprecationWarnings yet again.

So perhaps it was good to wait so long ;)

@derks
Copy link
Member

derks commented Dec 23, 2023

Many thanks @sigma67 ... FWIW, I am planning to sprint this week and this is top of the list.

@derks derks merged commit 51e7006 into datafolklabs:main Dec 26, 2023
1 check failed
@derks
Copy link
Member

derks commented Dec 26, 2023

@sigma67 @jonlowrey this has been merged to main. All tests pass on Python 3.7+ so it can roll out to next stable/3.0 release (after this current holiday sprint).

Thank you @sigma67 for your work on this... it is very much appreciated.

@sigma67
Copy link
Contributor Author

sigma67 commented Dec 26, 2023

@derks for sure! glad you found the time to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants