-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deprecated imp usage (#386) #656
Conversation
Hi @derks, it seems the tests are passing except for some unrelated failures. We also released this version internally and tested with our cement app under 3.12 and everything is working as expected. |
Is there a scheduled release date for this fix? I'm running into issues with the above mentioned aws-elasticbenastalk package via the aws-elastic-beanstalk-cli which we use for our deployment. Downgrading to 3.11 does fix my issue in the short term. Thank you both for maintaining critical infrastructure. |
I haven't heard anything from @derks in a while. We've released the package internally with the fix and it's working fine for us. For release use |
Thank you all for the feedback and effort in the PR. Due to starting a new job a few months ago I've been distracting and apologize for missing this. As the PR is tested and in use I'll look at this ASAP. |
Hi @derks, I have noticed an issue with my implementation that was causing So perhaps it was good to wait so long ;) |
Many thanks @sigma67 ... FWIW, I am planning to sprint this week and this is top of the list. |
@sigma67 @jonlowrey this has been merged to main. All tests pass on Python 3.7+ so it can roll out to next stable/3.0 release (after this current holiday sprint). Thank you @sigma67 for your work on this... it is very much appreciated. |
@derks for sure! glad you found the time to merge |
NOTICE: Prior to submitting a pull request, please ensure you abide by the
Guidelines for Code Contributions, including but not limited to:
Issue: #386