Skip to content

Fix bazel build //... for our distro by bumping versions #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Fix bazel build //... for our distro by bumping versions #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beba874
Fix bazel build //... for our distro by bumping versions
Jan 6, 2023
31c5679
Bump bazel to 5.4.0
Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am suprised this works, but if the tests are passing, that's awesome :D

Copy link
Contributor Author

@Ekrekr Ekrekr Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it breaks at 6.0.0 because docker rules can't support that, but 5.4.0 seems fine locally!

Cloud build tests time out on the PR, but it looks like it's just because postgres flaked - will retry.

5.4.0
2 changes: 1 addition & 1 deletion tools/gcloud/repository_rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ def _gcloud_sdk_impl(ctx):
gcloud_sdk = repository_rule(
implementation = _gcloud_sdk_impl,
attrs = {
"version": attr.string(default = "318.0.0"),
"version": attr.string(default = "412.0.0"),
},
)
2 changes: 1 addition & 1 deletion vscode/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function gatherAllActions(

function retrieveLinkedFileName(ref: string) {
const allActions = gatherAllActions();
const foundCompileAction = allActions.find(action => action.name.split(".").slice(-1)[0] === ref);
const foundCompileAction = allActions.find(action => action.target.name === ref);
return foundCompileAction.fileName;
}

Expand Down