Conversation
Collaborator
ahmed-mez
commented
Nov 21, 2025
ahmed-mez
commented
- Bump datafusion version to v51
- Adapt deps and code to datafusion v51.
gabotechs
reviewed
Nov 21, 2025
Comment on lines
-54
to
-57
| // TODO: The PhysicalExtensionCodec trait doesn't provide access to session state, | ||
| // so we create a new SessionContext which loses any custom UDFs, UDAFs, and other | ||
| // user configurations. This is a limitation of the current trait design. | ||
| let state = SessionStateBuilder::new() |
Comment on lines
+292
to
+293
| // TODO: Support these metrics | ||
| internal_err!("{}", UNSUPPORTED_METRICS) |
Collaborator
There was a problem hiding this comment.
Probably worth opening an issue for supporting this ones.
Comment on lines
-22
to
+26
| tonic = { version = "0.13.1", features = ["transport"] } | ||
| tonic = { version = "0.14.2", features = ["transport"] } |
Collaborator
There was a problem hiding this comment.
🤔 any chance to leave this as 0.13?
Collaborator
There was a problem hiding this comment.
Actually, I checked and nope. The best thing we can do is leave it at 0.14.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.