Replace explain_analyze.rs tests with more scoped metrics_collection.rs tests #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
force-pushed
the
gabrielmusat/add-metrics-collection-tests
branch
from
ca1e4b9 to
d51b349
Compare
gabotechs
force-pushed
the
gabrielmusat/add-metrics-collection-tests
branch
from
d51b349 to
1a55cbd
Compare
jayshrivastava
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
explain_analyze.rstests break on each DataFusion upgrade, and ideally that should not be the case, as our current solution for propagating metrics is supposed to be valid for any DataFusion version, so in this PR we remove theexplain_analyze.rstests in favor of a more scopedmetrics_collection.rstest that should be valid across DataFusion upgrades.