Support OutputBytes, OutputBatches, PruningMetrics, and Ratio metrics#305
Merged
jayshrivastava merged 1 commit intomainfrom Jan 22, 2026
Merged
Support OutputBytes, OutputBatches, PruningMetrics, and Ratio metrics#305jayshrivastava merged 1 commit intomainfrom
jayshrivastava merged 1 commit intomainfrom
Conversation
Add proto serialization support for four additional DataFusion metric types that were previously filtered out during metrics collection. This enables these metrics to be transferred across network boundaries in distributed query execution and displayed in explain analyze output. Closes #237
jayshrivastava
force-pushed
the
js/support-more-metrics
branch
from
27429d9 to
36f6ff2
Compare
gabotechs
approved these changes
Jan 22, 2026
Comment on lines
-15
to
+21
| #[prost(message, repeated, tag = "12")] | ||
| #[prost(message, repeated, tag = "16")] | ||
| pub labels: Vec<ProtoLabel>, | ||
| #[prost(uint64, optional, tag = "13")] | ||
| #[prost(uint64, optional, tag = "17")] |
Collaborator
There was a problem hiding this comment.
For now it's completely fine, but at some point we'll need to keep in mind backwards compatibility. Completely fine now as we are not guaranteeing that changes are backwards compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proto serialization support for four additional DataFusion metric types that were previously filtered out during metrics collection. This enables these metrics to be transferred across network boundaries in distributed query execution and displayed in explain analyze output.
Closes #237