SQLite: Validate expected indexes when attaching local datasets #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs adds verification of expected indexes when attaching local datasets to SQLite. This change ensures that the schema of the local copy of a table matches the expected configuration.
Note: created composite indexes can have complex names, produced index name information is easy to troubleshoot IMO so converting index name back to original configuration for tracing has not been added (NOTE: it is also not always possible or trivial, for example I have the following index
i_taxi_trips_fare_amount_passenger_count_total_amount_tpep_dropoff_datetime_tpep_pickup_datetime_trip_distance
) generated from test configuration'(tpep_pickup_datetime, tpep_dropoff_datetime, trip_distance, fare_amount, passenger_count, total_amount)': unique
Sample output:
In progress: unit test for
get_indexes
Note: similar improvement must be done for
primary_key