Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search autosuggest improvements #11

Open
2 of 3 tasks
filip-kopecky opened this issue Aug 31, 2021 · 0 comments
Open
2 of 3 tasks

Search autosuggest improvements #11

filip-kopecky opened this issue Aug 31, 2021 · 0 comments

Comments

@filip-kopecky
Copy link
Contributor

filip-kopecky commented Aug 31, 2021 •
edited
Loading

  • Limiting the number of autosuggest search results so that there is no scrollbar in the box. If there is more results there may perhaps be some link at the bottom to the full search, or a note that there are X more results.

  • Not displaying the popup panel when loading is in progress - the circular indicator within the input field is good enough for that.

  • Clicking on the search icon on the right of the input should redirect to search results.
filip-kopecky added a commit that referenced this issue Oct 26, 2021
@filip-kopecky
[#11] Search Icon is clickable
9b76772 
Search icon now triggers search on click
filip-kopecky added a commit that referenced this issue Nov 2, 2021
@filip-kopecky
[#11] Autocomplete behaves in more intuitive way
1f9f817 
When mouse leaves the search suggestions, the previously highlighted option is no longer highlighted and the text inside the input is considered to be active ("highlighted")
filip-kopecky added a commit that referenced this issue Nov 2, 2021
@filip-kopecky
[#11] Added types and comments
3875f73
filip-kopecky added a commit that referenced this issue Nov 2, 2021
@filip-kopecky
[#11] Forgot to remove testing attr
2c7f4e3
filip-kopecky added a commit that referenced this issue Nov 2, 2021
@filip-kopecky
[#11] Clicking on item fix
b640a87 
Click in the suggestion box wasn't registered correctly
filip-kopecky added a commit that referenced this issue Nov 2, 2021
@filip-kopecky
[#11] Clean up
13ce86d
filip-kopecky added a commit that referenced this issue Nov 3, 2021
@filip-kopecky
[#11] Rebuilt the search bar suggestion for the upcoming merge
bfc8fc9 
The "funny" behaviour of the autocomplete component was rewritten to be usable in the upcoming merge with the PoC PR.
filip-kopecky added a commit that referenced this issue Nov 3, 2021
@filip-kopecky
[#11] Moved lnline funcs to separate funcs
9f09ce2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filip-kopecky