Merge pull request #44 from kbss-cvut/1364-code-review

[#1364] Minor code optimization.
datagov-cz · Nov 10, 2020 · 0c9c7c9 · 0c9c7c9
2 parents 77f408b + 85464bc
commit 0c9c7c9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/src/component/term/TermDetail.tsx b/src/component/term/TermDetail.tsx
@@ -169,13 +169,12 @@ export class TermDetail extends EditableComponent<TermDetailProps, TermDetailSta
         if (this.props.validationResults && this.props.validationResults[this.props.vocabulary.iri]) {
             score = this.computeScore(this.props.validationResults[this.props.vocabulary.iri].filter(result => result.term.iri === this.props.term?.iri));
         }
-        const emptyString = "  ";
         return <Badge color={this.setBadgeColor(score)}
                       className="term-quality-badge"
-                      title={"The score of this term is " + score + "%. Click to see the validation results."}
+                      title={(score !== undefined) ? this.props.formatMessage("term.badge.score.tooltip", {score}) : this.props.i18n("term.badge.no-score.tooltip")}
                       onClick={this.onBadgeClick}
-        > {emptyString}
-        </Badge>
+        >&nbsp;
+        </Badge>;
     }
 
     public render() {

diff --git a/src/component/term/Terms.scss b/src/component/term/Terms.scss
@@ -12,4 +12,8 @@
 .term-quality-badge {
   margin-right: 0.5rem;
   cursor: pointer;
+  width: 0.1rem;
+  height: 0.1rem;
+  position: relative;
+  top: 0.35rem;
 }
diff --git a/src/i18n/cs.ts b/src/i18n/cs.ts
@@ -331,6 +331,8 @@ export default {
         "term.metadata.status.help" : "Rozpracovaný pojem není připraven k používání, zatímco schválený ano.",
         "term.metadata.types.select.placeholder": "Vyberte typ",
         "term.removed.message": "Pojem by odstraněn.",
+        "term.badge.score.tooltip": "Skóre tohoto pojmu je {score}%. Klikněte pro zobrazení výsledků kontroly",
+        "term.badge.no-score.tooltip": "Pro tento pojem není skóre k dispozici",
 
         "glossary.title": "Pojmy",
         "glossary.new": "Nový pojem",

diff --git a/src/i18n/en.ts b/src/i18n/en.ts
@@ -326,6 +326,8 @@ export default {
         "term.metadata.status.help" : "Draft term is not ready to be used yet, while Confirmed term is.",
         "term.metadata.types.select.placeholder": "Select type",
         "term.removed.message": "Term successfully removed.",
+        "term.badge.score.tooltip": "The score of this term is {score}%. Click to see the validation results",
+        "term.badge.no-score.tooltip": "There is no available score for this term",
 
         "glossary.title": "Terms",
         "glossary.new": "New Term",