-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into fix-json-patch-edge-case
- Loading branch information
Showing
83 changed files
with
4,135 additions
and
1,093 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/assertion/AssertionUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.linkedin.datahub.graphql.resolvers.assertion; | ||
|
|
||
| import com.datahub.authorization.ConjunctivePrivilegeGroup; | ||
| import com.datahub.authorization.DisjunctivePrivilegeGroup; | ||
| import com.google.common.collect.ImmutableList; | ||
| import com.linkedin.common.urn.Urn; | ||
| import com.linkedin.datahub.graphql.QueryContext; | ||
| import com.linkedin.datahub.graphql.authorization.AuthorizationUtils; | ||
| import com.linkedin.metadata.authorization.PoliciesConfig; | ||
|
|
||
| public class AssertionUtils { | ||
| public static boolean isAuthorizedToEditAssertionFromAssertee( | ||
| final QueryContext context, final Urn asserteeUrn) { | ||
| final DisjunctivePrivilegeGroup orPrivilegeGroups = | ||
| new DisjunctivePrivilegeGroup( | ||
| ImmutableList.of( | ||
| AuthorizationUtils.ALL_PRIVILEGES_GROUP, | ||
| new ConjunctivePrivilegeGroup( | ||
| ImmutableList.of(PoliciesConfig.EDIT_ENTITY_ASSERTIONS_PRIVILEGE.getType())))); | ||
| return AuthorizationUtils.isAuthorized( | ||
| context.getAuthorizer(), | ||
| context.getActorUrn(), | ||
| asserteeUrn.getEntityType(), | ||
| asserteeUrn.toString(), | ||
| orPrivilegeGroups); | ||
| } | ||
| } |
113 changes: 113 additions & 0 deletions
113
.../java/com/linkedin/datahub/graphql/resolvers/assertion/ReportAssertionResultResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| package com.linkedin.datahub.graphql.resolvers.assertion; | ||
|
|
||
| import static com.linkedin.datahub.graphql.resolvers.ResolverUtils.*; | ||
|
|
||
| import com.linkedin.assertion.AssertionResult; | ||
| import com.linkedin.assertion.AssertionResultError; | ||
| import com.linkedin.assertion.AssertionResultErrorType; | ||
| import com.linkedin.assertion.AssertionResultType; | ||
| import com.linkedin.common.urn.Urn; | ||
| import com.linkedin.common.urn.UrnUtils; | ||
| import com.linkedin.data.template.SetMode; | ||
| import com.linkedin.data.template.StringMap; | ||
| import com.linkedin.datahub.graphql.QueryContext; | ||
| import com.linkedin.datahub.graphql.exception.AuthorizationException; | ||
| import com.linkedin.datahub.graphql.generated.AssertionResultInput; | ||
| import com.linkedin.datahub.graphql.generated.StringMapEntryInput; | ||
| import com.linkedin.metadata.service.AssertionService; | ||
| import graphql.execution.DataFetcherExceptionHandler; | ||
| import graphql.execution.DataFetcherResult; | ||
| import graphql.schema.DataFetcher; | ||
| import graphql.schema.DataFetchingEnvironment; | ||
| import java.util.List; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| @Slf4j | ||
| public class ReportAssertionResultResolver implements DataFetcher<CompletableFuture<Boolean>> { | ||
|
|
||
| public static final String ERROR_MESSAGE_KEY = "message"; | ||
| private final AssertionService _assertionService; | ||
|
|
||
| public ReportAssertionResultResolver(AssertionService assertionService) { | ||
| _assertionService = assertionService; | ||
| } | ||
|
|
||
| /** | ||
| * This is called by the graphql engine to fetch the value. The {@link DataFetchingEnvironment} is | ||
| * a composite context object that tells you all you need to know about how to fetch a data value | ||
| * in graphql type terms. | ||
| * | ||
| * @param environment this is the data fetching environment which contains all the context you | ||
| * need to fetch a value | ||
| * @return a value of type T. May be wrapped in a {@link DataFetcherResult} | ||
| * @throws Exception to relieve the implementations from having to wrap checked exceptions. Any | ||
| * exception thrown from a {@code DataFetcher} will eventually be handled by the registered | ||
| * {@link DataFetcherExceptionHandler} and the related field will have a value of {@code null} | ||
| * in the result. | ||
| */ | ||
| @Override | ||
| public CompletableFuture<Boolean> get(DataFetchingEnvironment environment) throws Exception { | ||
| final QueryContext context = environment.getContext(); | ||
| final Urn assertionUrn = UrnUtils.getUrn(environment.getArgument("urn")); | ||
| final AssertionResultInput input = | ||
| bindArgument(environment.getArgument("result"), AssertionResultInput.class); | ||
|
|
||
| return CompletableFuture.supplyAsync( | ||
| () -> { | ||
| final Urn asserteeUrn = | ||
| _assertionService.getEntityUrnForAssertion( | ||
| context.getOperationContext(), assertionUrn); | ||
| if (asserteeUrn == null) { | ||
| throw new RuntimeException( | ||
| String.format( | ||
| "Failed to report Assertion Run Event. Assertion with urn %s does not exist or is not associated with any entity.", | ||
| assertionUrn)); | ||
| } | ||
|
|
||
| // Check whether the current user is allowed to update the assertion. | ||
| if (AssertionUtils.isAuthorizedToEditAssertionFromAssertee(context, asserteeUrn)) { | ||
| AssertionResult assertionResult = mapAssertionResult(input); | ||
| _assertionService.addAssertionRunEvent( | ||
| context.getOperationContext(), | ||
| assertionUrn, | ||
| asserteeUrn, | ||
| input.getTimestampMillis(), | ||
| assertionResult, | ||
| mapContextParameters(input.getProperties())); | ||
| return true; | ||
| } | ||
| throw new AuthorizationException( | ||
| "Unauthorized to perform this action. Please contact your DataHub administrator."); | ||
| }); | ||
| } | ||
|
|
||
| private static StringMap mapContextParameters(List<StringMapEntryInput> input) { | ||
|
|
||
| if (input == null || input.isEmpty()) { | ||
| return null; | ||
| } | ||
| StringMap entries = new StringMap(); | ||
| input.forEach(entry -> entries.put(entry.getKey(), entry.getValue())); | ||
| return entries; | ||
| } | ||
|
|
||
| private AssertionResult mapAssertionResult(AssertionResultInput input) { | ||
| AssertionResult assertionResult = new AssertionResult(); | ||
| assertionResult.setType(AssertionResultType.valueOf(input.getType().toString())); | ||
| assertionResult.setExternalUrl(input.getExternalUrl(), SetMode.IGNORE_NULL); | ||
| if (assertionResult.getType() == AssertionResultType.ERROR && input.getError() != null) { | ||
| assertionResult.setError(mapAssertionResultError(input)); | ||
| } | ||
| return assertionResult; | ||
| } | ||
|
|
||
| private static AssertionResultError mapAssertionResultError(AssertionResultInput input) { | ||
| AssertionResultError error = new AssertionResultError(); | ||
| error.setType(AssertionResultErrorType.valueOf(input.getError().getType().toString())); | ||
| StringMap errorProperties = new StringMap(); | ||
| errorProperties.put(ERROR_MESSAGE_KEY, input.getError().getMessage()); | ||
| error.setProperties(errorProperties); | ||
| return error; | ||
| } | ||
| } |
108 changes: 108 additions & 0 deletions
108
.../java/com/linkedin/datahub/graphql/resolvers/assertion/UpsertCustomAssertionResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| package com.linkedin.datahub.graphql.resolvers.assertion; | ||
|
|
||
| import static com.linkedin.datahub.graphql.resolvers.ResolverUtils.*; | ||
| import static com.linkedin.metadata.Constants.*; | ||
|
|
||
| import com.linkedin.assertion.CustomAssertionInfo; | ||
| import com.linkedin.common.DataPlatformInstance; | ||
| import com.linkedin.common.urn.Urn; | ||
| import com.linkedin.common.urn.UrnUtils; | ||
| import com.linkedin.data.template.SetMode; | ||
| import com.linkedin.datahub.graphql.QueryContext; | ||
| import com.linkedin.datahub.graphql.exception.AuthorizationException; | ||
| import com.linkedin.datahub.graphql.generated.Assertion; | ||
| import com.linkedin.datahub.graphql.generated.PlatformInput; | ||
| import com.linkedin.datahub.graphql.generated.UpsertCustomAssertionInput; | ||
| import com.linkedin.datahub.graphql.types.assertion.AssertionMapper; | ||
| import com.linkedin.metadata.key.DataPlatformKey; | ||
| import com.linkedin.metadata.service.AssertionService; | ||
| import com.linkedin.metadata.utils.EntityKeyUtils; | ||
| import com.linkedin.metadata.utils.SchemaFieldUtils; | ||
| import graphql.schema.DataFetcher; | ||
| import graphql.schema.DataFetchingEnvironment; | ||
| import java.util.Objects; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import javax.annotation.Nonnull; | ||
| import lombok.SneakyThrows; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| @Slf4j | ||
| public class UpsertCustomAssertionResolver implements DataFetcher<CompletableFuture<Assertion>> { | ||
|
|
||
| private final AssertionService _assertionService; | ||
|
|
||
| public UpsertCustomAssertionResolver(@Nonnull final AssertionService assertionService) { | ||
| _assertionService = Objects.requireNonNull(assertionService, "assertionService is required"); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Assertion> get(DataFetchingEnvironment environment) throws Exception { | ||
| final QueryContext context = environment.getContext(); | ||
| final String maybeAssertionUrn = environment.getArgument("urn"); | ||
| final UpsertCustomAssertionInput input = | ||
| bindArgument(environment.getArgument("input"), UpsertCustomAssertionInput.class); | ||
|
|
||
| final Urn entityUrn = UrnUtils.getUrn(input.getEntityUrn()); | ||
| final Urn assertionUrn; | ||
|
|
||
| if (maybeAssertionUrn == null) { | ||
| assertionUrn = _assertionService.generateAssertionUrn(); | ||
| } else { | ||
| assertionUrn = UrnUtils.getUrn(maybeAssertionUrn); | ||
| } | ||
|
|
||
| return CompletableFuture.supplyAsync( | ||
| () -> { | ||
| // Check whether the current user is allowed to update the assertion. | ||
| if (AssertionUtils.isAuthorizedToEditAssertionFromAssertee(context, entityUrn)) { | ||
| _assertionService.upsertCustomAssertion( | ||
| context.getOperationContext(), | ||
| assertionUrn, | ||
| entityUrn, | ||
| input.getDescription(), | ||
| input.getExternalUrl(), | ||
| mapAssertionPlatform(input.getPlatform()), | ||
| createCustomAssertionInfo(input, entityUrn)); | ||
|
|
||
| return AssertionMapper.map( | ||
| context, | ||
| _assertionService.getAssertionEntityResponse( | ||
| context.getOperationContext(), assertionUrn)); | ||
| } | ||
| throw new AuthorizationException( | ||
| "Unauthorized to perform this action. Please contact your DataHub administrator."); | ||
| }); | ||
| } | ||
|
|
||
| @SneakyThrows | ||
| private DataPlatformInstance mapAssertionPlatform(PlatformInput platformInput) { | ||
| DataPlatformInstance platform = new DataPlatformInstance(); | ||
| if (platformInput.getUrn() != null) { | ||
| platform.setPlatform(Urn.createFromString(platformInput.getUrn())); | ||
| } else if (platformInput.getName() != null) { | ||
| platform.setPlatform( | ||
| EntityKeyUtils.convertEntityKeyToUrn( | ||
| new DataPlatformKey().setPlatformName(platformInput.getName()), | ||
| DATA_PLATFORM_ENTITY_NAME)); | ||
| } else { | ||
| throw new IllegalArgumentException( | ||
| "Failed to upsert Custom Assertion. Platform Name or Platform Urn must be specified."); | ||
| } | ||
|
|
||
| return platform; | ||
| } | ||
|
|
||
| private CustomAssertionInfo createCustomAssertionInfo( | ||
| UpsertCustomAssertionInput input, Urn entityUrn) { | ||
| CustomAssertionInfo customAssertionInfo = new CustomAssertionInfo(); | ||
| customAssertionInfo.setType(input.getType()); | ||
| customAssertionInfo.setEntity(entityUrn); | ||
| customAssertionInfo.setLogic(input.getLogic(), SetMode.IGNORE_NULL); | ||
|
|
||
| if (input.getFieldPath() != null) { | ||
| customAssertionInfo.setField( | ||
| SchemaFieldUtils.generateSchemaFieldUrn(entityUrn.toString(), input.getFieldPath())); | ||
| } | ||
| return customAssertionInfo; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.