refactor(smoke): use env variables (#6866)

datahub-project · Dec 29, 2022 · 1d0bb1c · 1d0bb1c
1 parent 122c024
commit 1d0bb1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/smoke-test/tests/cypress/cypress/integration/login/login.js b/smoke-test/tests/cypress/cypress/integration/login/login.js
@@ -1,8 +1,8 @@
 describe('login', () => {
   it('logs in', () => {
     cy.visit('/');
-    cy.get('input[data-testid=username]').type('datahub');
-    cy.get('input[data-testid=password]').type('datahub');
+    cy.get('input[data-testid=username]').type(Cypress.env('ADMIN_USERNAME'));
+    cy.get('input[data-testid=password]').type(Cypress.env('ADMIN_PASSWORD'));
     cy.contains('Sign In').click();
     cy.contains('Welcome back, DataHub');
   });

diff --git a/smoke-test/tests/utils.py b/smoke-test/tests/utils.py
@@ -27,7 +27,7 @@ def get_frontend_session():
 
 
 def get_admin_username() -> str:
-    return os.getenv("ADMIN_USERNAME", "datahub")
+    return get_admin_credentials()[0]
 
 
 def get_admin_credentials():