Skip to content

Commit

Permalink
feat(bigquery): reduce logging (#4961)
Browse files Browse the repository at this point in the history
* feat(bigquery): reduce logging

* doc: add entry for behaviour change
  • Loading branch information
anshbansal authored May 20, 2022
1 parent c99b167 commit 2260118
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/how/updating-datahub.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
### Deprecations

### Other notable Changes
- #4961 Dropped profiling is not reported by default as that caused a lot of spurious logging in some cases. Set `profiling.report_dropped_profiles` to `True` if you want older behaviour.

## `v0.8.35`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ class GEProfilingConfig(ConfigModel):
default=None,
description="Offset in documents to profile. By default, uses no offset.",
)
report_dropped_profiles: bool = Field(
default=False,
description="If datasets which were not profiled are reported in source report or not. Set to `True` for debugging purposes.",
)

# These settings will override the ones below.
turn_off_expensive_profiling_metrics: bool = Field(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,8 @@ def loop_profiler_requests(
schema=schema, entity=table, inspector=inspector
)
if not self.is_dataset_eligible_for_profiling(dataset_name, sql_config):
self.report.report_dropped(f"profile of {dataset_name}")
if self.config.profiling.report_dropped_profiles:
self.report.report_dropped(f"profile of {dataset_name}")
continue

dataset_name = self.normalise_dataset_name(dataset_name)
Expand Down

0 comments on commit 2260118

Please sign in to comment.