fix(ingest): issue a warning if the column list is empty (#2912)

datahub-project · Jul 20, 2021 · 267efe7 · 267efe7
1 parent 6abd5e1
commit 267efe7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql_common.py b/metadata-ingestion/src/datahub/ingestion/source/sql_common.py
@@ -298,6 +298,9 @@ def loop_tables(
                 continue
 
             columns = inspector.get_columns(table, schema)
+            if len(columns) == 0:
+                self.report.report_warning(dataset_name, "missing column information")
+
             try:
                 # SQLALchemy stubs are incomplete and missing this method.
                 # PR: https://github.com/dropbox/sqlalchemy-stubs/pull/223.
@@ -322,7 +325,6 @@ def loop_tables(
                 dataset_properties = DatasetPropertiesClass(
                     description=description,
                     customProperties=properties,
-                    # uri=dataset_name,
                 )
                 dataset_snapshot.aspects.append(dataset_properties)
             schema_metadata = get_schema_metadata(