feat(observe) expose assertion runId and lastObservedMillis to graphql (

#10726)
datahub-project · Jul 16, 2024 · 31cd807 · 31cd807
1 parent cd4e8d0
commit 31cd807
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/...main/java/com/linkedin/datahub/graphql/types/dataset/mappers/AssertionRunEventMapper.java b/...main/java/com/linkedin/datahub/graphql/types/dataset/mappers/AssertionRunEventMapper.java
@@ -38,6 +38,7 @@ public com.linkedin.datahub.graphql.generated.AssertionRunEvent apply(
  final com.linkedin.datahub.graphql.generated.AssertionRunEvent assertionRunEvent =
  new com.linkedin.datahub.graphql.generated.AssertionRunEvent();
 
+ assertionRunEvent.setLastObservedMillis(envelopedAspect.getSystemMetadata().getLastObserved());
  assertionRunEvent.setTimestampMillis(gmsAssertionRunEvent.getTimestampMillis());
  assertionRunEvent.setAssertionUrn(gmsAssertionRunEvent.getAssertionUrn().toString());
  assertionRunEvent.setAsserteeUrn(gmsAssertionRunEvent.getAsserteeUrn().toString());

diff --git a/datahub-graphql-core/src/main/resources/entity.graphql b/datahub-graphql-core/src/main/resources/entity.graphql
@@ -7404,6 +7404,11 @@ type AssertionRunEvent implements TimeSeriesAspect {
  """
  timestampMillis: Long!
 
+ """
+ The time at which the run event was last observed by the DataHub system - ie, when it was reported by external systems
+ """
+ lastObservedMillis: Long
+
  """
  Urn of assertion which is evaluated
  """
@@ -7420,7 +7425,7 @@ type AssertionRunEvent implements TimeSeriesAspect {
  runId: String!
 
  """
- The status of the assertion run as per this timeseries event.
+ The status of the assertion run as per this timeseries event
  """
  status: AssertionRunStatus!
 

diff --git a/.../java/com/linkedin/datahub/graphql/resolvers/assertion/AssertionRunEventResolverTest.java b/.../java/com/linkedin/datahub/graphql/resolvers/assertion/AssertionRunEventResolverTest.java
@@ -18,6 +18,7 @@
 import com.linkedin.metadata.aspect.EnvelopedAspect;
 import com.linkedin.metadata.query.filter.Filter;
 import com.linkedin.metadata.utils.GenericRecordUtils;
+import com.linkedin.mxe.SystemMetadata;
 import graphql.schema.DataFetchingEnvironment;
 import org.mockito.Mockito;
 import org.testng.annotations.Test;
@@ -58,7 +59,9 @@ public void testGetSuccess() throws Exception {
  null, AssertionRunStatus.COMPLETE.toString()))))
  .thenReturn(
  ImmutableList.of(
- new EnvelopedAspect().setAspect(GenericRecordUtils.serializeAspect(gmsRunEvent))));
+ new EnvelopedAspect()
+ .setAspect(GenericRecordUtils.serializeAspect(gmsRunEvent))
+ .setSystemMetadata(new SystemMetadata().setLastObserved(12L))));
 
  AssertionRunEventResolver resolver = new AssertionRunEventResolver(mockClient);
 
@@ -108,6 +111,7 @@ public void testGetSuccess() throws Exception {
  graphqlRunEvent.getStatus(),
  com.linkedin.datahub.graphql.generated.AssertionRunStatus.COMPLETE);
  assertEquals((float) graphqlRunEvent.getTimestampMillis(), 12L);
+ assertEquals((float) graphqlRunEvent.getLastObservedMillis(), 12L);
  assertEquals((float) graphqlRunEvent.getResult().getActualAggValue(), 10);
  assertEquals((long) graphqlRunEvent.getResult().getMissingCount(), 0L);
  assertEquals((long) graphqlRunEvent.getResult().getRowCount(), 1L);

diff --git a/datahub-web-react/src/graphql/assertion.graphql b/datahub-web-react/src/graphql/assertion.graphql
@@ -55,8 +55,10 @@ fragment assertionDetails on Assertion {
 
 fragment assertionRunEventDetails on AssertionRunEvent {
  timestampMillis
+ lastObservedMillis
  assertionUrn
  status
+ runId
  runtimeContext {
  key
  value