feat(tags): improving elastic search templates for tags (#2254)

datahub-project · Mar 18, 2021 · 7106753 · 7106753
1 parent 8c8de74
commit 7106753
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 6 deletions.
diff --git a/datahub-web-react/src/app/shared/tags/AddTagModal.tsx b/datahub-web-react/src/app/shared/tags/AddTagModal.tsx
@@ -53,7 +53,7 @@ export default function AddTagModal({ updateTags, globalTags, visible, onClose }
             </Select.Option>
         )) || [];
 
-    if (!inputExistsInAutocomplete && inputValue.length > 2 && !loading) {
+    if (!inputExistsInAutocomplete && inputValue.length > 0 && !loading) {
         autocompleteOptions.push(
             <Select.Option value={CREATE_TAG_VALUE} key={CREATE_TAG_VALUE}>
                 <Typography.Link> Create {inputValue}</Typography.Link>
@@ -121,7 +121,7 @@ export default function AddTagModal({ updateTags, globalTags, visible, onClose }
                 onSelect={(selected) =>
                     selected === CREATE_TAG_VALUE ? setShowCreateModal(true) : setSelectedTagValue(String(selected))
                 }
-                notFoundContent={loading ? 'loading' : 'type at least 3 character to search'}
+                notFoundContent={loading ? 'loading' : 'type to search'}
             >
                 {autocompleteOptions}
             </TagSelect>

diff --git a/gms/impl/src/main/resources/datasetESSearchQueryTemplate.json b/gms/impl/src/main/resources/datasetESSearchQueryTemplate.json
@@ -56,6 +56,15 @@
               "default_field": "tags",
               "default_operator": "AND"
             }
+          },
+          {
+            "query_string": {
+              "query": "$INPUT",
+              "analyzer": "whitespace_lowercase",
+              "boost": 0.0625,
+              "default_field": "tags.ngram",
+              "default_operator": "AND"
+            }
           }
         ]
       }
@@ -104,4 +113,4 @@
     ],
     "score_mode": "multiply"
   }
-}
+}
diff --git a/gms/impl/src/main/resources/index/dataset/mappings.json b/gms/impl/src/main/resources/index/dataset/mappings.json
@@ -118,7 +118,13 @@
     },
     "tags": {
       "type": "keyword",
-      "normalizer": "my_normalizer"
+      "normalizer": "my_normalizer",
+      "fields": {
+        "ngram": {
+          "type": "text",
+          "analyzer": "custom_ngram"
+        }
+      }
     }
   }
-}
+}
diff --git a/gms/impl/src/main/resources/index/tags/settings.json b/gms/impl/src/main/resources/index/tags/settings.json
@@ -4,7 +4,7 @@
       "filter": {
         "autocomplete_filter": {
           "type": "edge_ngram",
-          "min_gram": "3",
+          "min_gram": "1",
           "max_gram": "20"
         },
         "custom_delimiter": {