Skip to content

Commit

Permalink
Merge branch 'master' into cus2192-report-lineage-issue
Browse files Browse the repository at this point in the history
  • Loading branch information
sid-acryl committed Jul 24, 2024
2 parents 4130d5b + 959d351 commit 8c8941d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def mssql_runner(docker_compose_runner, pytestconfig):
time.sleep(5)

# Run the setup.sql file to populate the database.
command = "docker exec testsqlserver /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'test!Password' -d master -i /setup/setup.sql"
command = "docker exec testsqlserver /opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P 'test!Password' -d master -i /setup/setup.sql"
ret = subprocess.run(command, shell=True, capture_output=True)
assert ret.returncode == 0
yield docker_services
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2176,7 +2176,8 @@ public Set<Urn> exists(
urn ->
// key aspect is always returned, make sure to only consider the status aspect
statusResult.getOrDefault(urn, List.of()).stream()
.filter(aspect -> STATUS_ASPECT_NAME.equals(aspect.schema().getName()))
.filter(
aspect -> STATUS_ASPECT_NAME.equalsIgnoreCase(aspect.schema().getName()))
.noneMatch(aspect -> ((Status) aspect).isRemoved()))
.collect(Collectors.toSet());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ private static Optional<AspectValidationException> validateType(
throw new RuntimeException(e);
}
String allowedEntityName = getValueTypeId(typeUrn);
if (typeValue.getEntityType().equals(allowedEntityName)) {
if (typeValue.getEntityType().equalsIgnoreCase(allowedEntityName)) {
matchedAny = true;
}
}
Expand Down

0 comments on commit 8c8941d

Please sign in to comment.