Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
shirshanka committed Jul 30, 2024
1 parent b64c955 commit c7f8f23
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
5 changes: 1 addition & 4 deletions smoke-test/tests/schema_fields/test_schemafields.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@

import datahub.metadata.schema_classes as models
import pytest
from datahub.emitter.mce_builder import (
make_dataset_urn,
make_schema_field_urn,
)
from datahub.emitter.mce_builder import make_dataset_urn, make_schema_field_urn
from datahub.emitter.mcp import MetadataChangeProposalWrapper
from datahub.ingestion.api.common import PipelineContext, RecordEnvelope
from datahub.ingestion.api.sink import NoopWriteCallback
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,11 @@ def create_property_definition(
qualifiedName=f"{namespace}.{property_name}",
valueType=Urn.make_data_type_urn(value_type),
description="The retention policy for the dataset",
entityTypes=[Urn.make_entity_type_urn(e) for e in entity_types]
if entity_types
else [Urn.make_entity_type_urn("dataset")],
entityTypes=(
[Urn.make_entity_type_urn(e) for e in entity_types]
if entity_types
else [Urn.make_entity_type_urn("dataset")]
),
cardinality=cardinality,
allowedValues=allowed_values,
)
Expand All @@ -137,7 +139,7 @@ def create_property_definition(
def attach_property_to_entity(
urn: str,
property_name: str,
property_value: Union[str, float, List[str | float]],
property_value: Union[str, float, List[Union[str, float]]],
graph: DataHubGraph,
namespace: str = default_namespace,
):
Expand Down

0 comments on commit c7f8f23

Please sign in to comment.