fix type issue and linting

datahub-project · Jul 15, 2024 · cf95fe4 · cf95fe4
1 parent 70b1b11
commit cf95fe4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema.py b/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema.py
@@ -132,9 +132,9 @@ def __init__(self) -> None:
         )
 
         # self._table_tags[<database_name>][<schema_name>][<table_name>] = list of tags applied to table
-        self._table_tags: Dict[str, Dict[str, Dict[str, List[SnowflakeTag]]]] = (
-            defaultdict(lambda: defaultdict(lambda: defaultdict(list)))
-        )
+        self._table_tags: Dict[
+            str, Dict[str, Dict[str, List[SnowflakeTag]]]
+        ] = defaultdict(lambda: defaultdict(lambda: defaultdict(list)))
 
         # self._column_tags[<database_name>][<schema_name>][<table_name>][<column_name>] = list of tags applied to column
         self._column_tags: Dict[

diff --git a/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py b/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
@@ -171,9 +171,9 @@ def __init__(
             config, self.data_dictionary, self.report
         )
         self.profiler: Optional[SnowflakeProfiler] = profiler
-        self.snowsight_url_builder: Optional[SnowsightUrlBuilder] = (
-            snowsight_url_builder
-        )
+        self.snowsight_url_builder: Optional[
+            SnowsightUrlBuilder
+        ] = snowsight_url_builder
 
         # These are populated as side-effects of get_workunits_internal.
         self.databases: List[SnowflakeDatabase] = []
@@ -228,9 +228,9 @@ def get_databases(self) -> Optional[List[SnowflakeDatabase]]:
             )
             return None
         else:
-            ischema_databases: List[SnowflakeDatabase] = (
-                self.get_databases_from_ischema(databases)
-            )
+            ischema_databases: List[
+                SnowflakeDatabase
+            ] = self.get_databases_from_ischema(databases)
 
             if len(ischema_databases) == 0:
                 self.report_error(

diff --git a/metadata-models/src/main/pegasus/com/linkedin/dataset/ViewProperties.pdl b/metadata-models/src/main/pegasus/com/linkedin/dataset/ViewProperties.pdl
@@ -23,7 +23,7 @@ record ViewProperties {
   /**
    * The view logic
    */
-  viewLogic: string
+  viewLogic: optional string
 
   /**
    * The formatted view logic. This is particularly used for SQL sources, where the SQL