Skip to content

Commit

Permalink
chore(ingest): drop bigquery-beta and snowflake-beta aliases (#8451)
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 authored Jul 20, 2023
1 parent 47616ff commit d733363
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 30 deletions.
1 change: 1 addition & 0 deletions docs/how/updating-datahub.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
`profile_table_level_only` together with `include_field_xyz` config options to ingest
certain column-level metrics. Instead, set `profile_table_level_only` to `false` and
individually enable / disable desired field metrics.
- #8451: The `bigquery-beta` and `snowflake-beta` source aliases have been dropped. Use `bigquery` and `snowflake` as the source type instead.

### Potential Downtime

Expand Down
11 changes: 0 additions & 11 deletions metadata-ingestion/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,6 @@ def get_long_description():
"sqlalchemy-bigquery>=1.4.1",
"google-cloud-datacatalog-lineage==0.2.2",
},
"bigquery-beta": sql_common
| bigquery_common
| {
*sqllineage_lib,
*sqlglot_lib,
"sql_metadata",
"sqlalchemy-bigquery>=1.4.1",
}, # deprecated, but keeping the extra for backwards compatibility
"clickhouse": sql_common | clickhouse_common,
"clickhouse-usage": sql_common | usage_common | clickhouse_common,
"datahub-lineage-file": set(),
Expand Down Expand Up @@ -370,9 +362,6 @@ def get_long_description():
"sagemaker": aws_common,
"salesforce": {"simple-salesforce"},
"snowflake": snowflake_common | usage_common | sqlglot_lib,
"snowflake-beta": (
snowflake_common | usage_common | sqlglot_lib
), # deprecated, but keeping the extra for backwards compatibility
"sqlalchemy": sql_common,
"superset": {
"requests",
Expand Down
19 changes: 0 additions & 19 deletions metadata-ingestion/src/datahub/ingestion/source/source_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,6 @@
source_registry.register_from_entrypoint("datahub.ingestion.source.plugins")

# Deprecations.
source_registry.register_alias(
"snowflake-beta",
"snowflake",
lambda: warnings.warn(
"source type snowflake-beta is deprecated, use snowflake instead",
ConfigurationWarning,
stacklevel=3,
),
)
source_registry.register_alias(
"bigquery-beta",
"bigquery",
lambda: warnings.warn(
"source type bigquery-beta is deprecated, use bigquery instead",
ConfigurationWarning,
stacklevel=3,
),
)

source_registry.register_alias(
"redshift-usage",
"redshift-usage-legacy",
Expand Down

0 comments on commit d733363

Please sign in to comment.