Read deleted looker dashboards.

datahub-project · Aug 25, 2021 · ec2c03c · ec2c03c
1 parent d1b5792
commit ec2c03c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/looker.py b/metadata-ingestion/src/datahub/ingestion/source/looker.py
@@ -376,8 +376,8 @@ def _get_looker_dashboard(self, dashboard: Dashboard) -> LookerDashboard:
             description=dashboard.description,
             dashboard_elements=dashboard_elements,
             created_at=dashboard.created_at,
-            is_deleted=dashboard.deleted if dashboard.deleted is not None else False,
-            is_hidden=dashboard.deleted if dashboard.deleted is not None else False,
+            is_deleted=dashboard.deleted,
+            is_hidden=dashboard.deleted,
         )
         return looker_dashboard
 
@@ -399,7 +399,7 @@ def get_workunits(self) -> Iterable[MetadataWorkUnit]:
         client = self._get_looker_client()
         dashboard_ids = [
             dashboard_base.id
-            for dashboard_base in client.all_dashboards(fields="id")
+            for dashboard_base in client.all_dashboards(fields="id") + client.search_dashboards(fields="id", deleted="true")
             if dashboard_base.id is not None
         ]
 
@@ -409,7 +409,7 @@ def get_workunits(self) -> Iterable[MetadataWorkUnit]:
                 self.reporter.report_dashboards_dropped(dashboard_id)
                 continue
             try:
-                fields = ["id", "title", "dashboard_elements", "dashboard_filters"]
+                fields = ["id", "title", "dashboard_elements", "dashboard_filters", "deleted"]
                 dashboard_object = client.dashboard(
                     dashboard_id=dashboard_id, fields=",".join(fields)
                 )