BigQuery nested fields missing descriptions

[maaaikoool]

Describe the bug
BigQuery schemaMetadata aspect is missing description in record fields that are not the root record field.

To Reproduce
Steps to reproduce the behavior:

1. Ingest any dataset with a record.

pipeline_name: bigquery_test
source:
  type: bigquery
  config:
    match_fully_qualified_names: true
    include_table_lineage: false
    include_usage_statistics: false
    include_views: false
    project_id: pepe
    schema_pattern:
      allow:
      - "pepe.dataset"
    table_pattern:
      allow:
        - .*some_table_with_record
    use_date_sharded_audit_log_tables: false
    use_exported_bigquery_audit_metadata: false
    profiling:
      enabled: false
sink:
  type: file
  config:
      filename: out.json

Expected behavior
All fields should have description

Screenshots

Additional context
Tested with latest version master e7d140f

[maaaikoool]

I have debugged this and the issue seems to be related to this conditional here. This is only true for the struct field, hence it's the only one that has a description set.

Mentioning @treff7es as I see he was testing this here #6062

[github-actions]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[treff7es]

@maaaikoool please, can you retest?
I tried to reproduce but I was unable :(

And this is how it is ingested:

[maaaikoool]

Hey @treff7es after upgrading to v0.11.0.2 I can still reproduce it. Here is a minimal example:

[
  {
    "name": "root",
    "type": "RECORD",
    "description": "root",
    "fields": [
      {
        "name": "nested_record",
        "type": "RECORD",
        "description": "nested_record",
        "fields": [
          {
            "name": "value",
            "type": "STRING",
            "description": "value"
          }
        ]
      },
      {
        "name": "updatedAt",
        "type": "STRING",
        "description": "updatedAt"
      }
    ]
  }
]

updatedAt won't have a description 🤔