Fix(ingest/bigquery): fix extracting comments from complex types #8950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggiehays
added
the
community-contribution
github-actions
bot
added
the
ingestion
lusob
approved these changes
Oct 6, 2023
mayurinehate
requested changes
Oct 25, 2023
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery.py
Outdated
Show resolved
Hide resolved
…gquery.py add suggestion Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
lusob
approved these changes
Oct 25, 2023
lusob
approved these changes
Oct 25, 2023
maggiehays
added
the
hacktoberfest-accepted
mayurinehate
requested changes
Oct 26, 2023
There was a problem hiding this comment.
@maaaikoool can you please fix the lint ? https://github.com/datahub-project/datahub/actions/runs/6640885066/job/18042206118?pr=8950
mayurinehate
approved these changes
Oct 26, 2023
hsheth2
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8763
Fixes a conditional to extract the field description when the field is part of a record.
SchemaFields are lower case, whileBigQueryColumns have the original column name.Checklist