feat(ingest/looker): update browse paths to align with looker UI #10147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
commented
Mar 27, 2024
| dashboard_elements=[ | ||
| DashboardElement( | ||
| id="2", | ||
| type="", | ||
| type="vis", |
There was a problem hiding this comment.
Required due to this check, otherwise the charts don't get ingested
| } | ||
| }, | ||
| { | ||
| "proposedSnapshot": { | ||
| "com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot": { | ||
| "urn": "urn:li:dataset:(urn:li:dataPlatform:looker,data.explore.my_view,PROD)", | ||
| "urn": "urn:li:dataset:(urn:li:dataPlatform:looker,bogus data.explore.my_view,PROD)", |
There was a problem hiding this comment.
Not sure why - the order of mces for "bogus data" and "data" projects has changed.
hsheth2
reviewed
Mar 27, 2024
also - add comment about breaking change in browse path
mayurinehate
commented
Mar 28, 2024
| @@ -578,7 +578,7 @@ def test_lookml_git_info(pytestconfig, tmp_path, mock_time): | |||
| "parse_table_names_from_sql": True, | |||
| "project_name": "lkml_samples", | |||
| "model_pattern": {"deny": ["data2"]}, | |||
| "github_info": {"repo": "datahub/looker-demo", "branch": "master"}, | |||
| "git_info": {"repo": "datahub/looker-demo", "branch": "master"}, | |||
There was a problem hiding this comment.
This change is only to remove warnings when executing lookml tests.
5 tasks
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist