Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql-core):Auto completion/suggestion of Domains are not working #10150

Merged
merged 4 commits into from
Apr 5, 2024
Merged

fix(graphql-core):Auto completion/suggestion of Domains are not working #10150

merged 4 commits into from
Apr 5, 2024

Conversation

siladitya2
Copy link
Contributor

@siladitya2 siladitya2 commented Mar 27, 2024 •
edited
Loading

Issue: Domains are not appearing on auto-suggestion with autoCompleteForMultiple Graphql query

Root cause: Type Domains are not included inside AUTO_COMPLETE_ENTITY_TYPES that's why this code failed to include Domain type while doing autoCompleteForMultiple

Fix: include Domain also into AUTO_COMPLETE_ENTITY_TYPES

Test:
UI Screenshot with this PR fix:
Screenshot 2024-03-27 at 18 56 44

autoCompleteForMultiple Graphql Query result when type Domain is specified:|
Screenshot 2024-03-27 at 19 12 17

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@siladitya2 siladitya2 changed the title fix(graphql-core):include Domain into auto completion type fix(graphql-core):Include Domain into auto completion type Mar 27, 2024
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions labels Mar 27, 2024
@siladitya2 siladitya2 changed the title fix(graphql-core):Include Domain into auto completion type fix(graphql-core):Auto completion/suggestion of Domains are not working Mar 27, 2024
@myuk myuk assigned myuk and jjoyce0510 and unassigned myuk Mar 27, 2024
@myuk myuk requested a review from jjoyce0510 March 27, 2024 17:25
chriscollins3456
chriscollins3456 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you!

@chriscollins3456 chriscollins3456 merged commit 31c7ccc into datahub-project:master Apr 5, 2024
35 of 36 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@siladitya2 @chriscollins3456 @sleeperdeep
fix(graphql-core):Auto completion/suggestion of Domains are not worki…
f6df6d6 
…ng (datahub-project#10150)

Co-authored-by: si-chakraborty <si.chakraborty@adevinta.com>
Co-authored-by: Chris Collins <chriscollins3456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees

@chriscollins3456 chriscollins3456

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siladitya2 @chriscollins3456 @jjoyce0510 @myuk