Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix feedback button design #10182

Merged
merged 1 commit into from
Apr 8, 2024
Merged

docs: fix feedback button design #10182

merged 1 commit into from
Apr 8, 2024

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Apr 2, 2024 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

as-is :
image

to-be :
image

@yoonhyejin yoonhyejin requested a review from hsheth2 April 2, 2024 04:00
@yoonhyejin yoonhyejin merged commit 300e682 into master Apr 8, 2024
34 of 35 checks passed
@yoonhyejin yoonhyejin deleted the docs/fix-feedback-button branch April 8, 2024 03:37
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @sleeperdeep
docs: fix feedback button design (datahub-project#10182)
16c2032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2