fix(ingest/bigquery): fix lineage if multiple sql expression passed in and destination table set #10212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table set explicitly on the query UI
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Apr 8, 2024
| )""" | ||
| else: | ||
| query = e.query | ||
| except Exception: |
There was a problem hiding this comment.
now that we have the other PR merged, we should be able to revert this?
There was a problem hiding this comment.
This part is not full because we still need to wrap it into a create statement and get the last statement from the query.
The sanitized table name can be reverted but do you think it can cause any harm if we do here as well?
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…n and destination table set (datahub-project#10212) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix lineage if multiple sql expression passed in and destination table set on the query UI
Checklist