Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add slack utm component in docs #10214

Merged
merged 4 commits into from
Apr 30, 2024
Merged

docs: add slack utm component in docs #10214

merged 4 commits into from
Apr 30, 2024

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yoonhyejin yoonhyejin requested a review from hsheth2 April 5, 2024 08:14
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Apr 5, 2024
@yoonhyejin yoonhyejin requested a review from hsheth2 April 23, 2024 06:39
@yoonhyejin yoonhyejin changed the title docs: add slack utm in docs docs: add slack utm component in docs Apr 23, 2024
@yoonhyejin
Copy link
Collaborator Author

@hsheth2 PTAL i changed it to the react component

hsheth2
hsheth2 approved these changes Apr 23, 2024
View reviewed changes
docs-website/src/components/SlackUtm/index.js Outdated Show resolved Hide resolved
docs-website/src/components/SlackUtm/supabase.js Outdated Show resolved Hide resolved
docs-website/src/components/SlackUtm/index.js Outdated Show resolved Hide resolved
metadata-ingestion/sink_docs/datahub.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin merged commit 704ca65 into master Apr 30, 2024
56 of 57 checks passed
@yoonhyejin yoonhyejin deleted the docs/add-utm branch April 30, 2024 03:54
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @sleeperdeep
docs: add slack utm component in docs (datahub-project#10214)
9d1f342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2