feat(ingest/cockroachdb): add cockroachdb ingestion #10226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for cockroachdb ingestion based on postgres ingestion as it postgres compatible
github-actions
bot
added
ingestion
hsheth2
reviewed
Apr 8, 2024
metadata-ingestion/setup.py
Outdated
| @@ -311,6 +311,7 @@ | |||
| | classification_lib, | |||
| "clickhouse": sql_common | clickhouse_common, | |||
| "clickhouse-usage": sql_common | usage_common | clickhouse_common, | |||
| "cockroachdb": sql_common | {"psycopg2-binary", "GeoAlchemy2", "sqlalchemy-cockroachdb<2.0.0"}, | |||
There was a problem hiding this comment.
Let's extract out a postgres_common and use that here and for postgres - that way it's a bit more clear that this is built on top of postgres
| config = CockroachDBConfig.parse_obj(config_dict) | ||
| return cls(config, ctx) | ||
|
|
||
| pass |
…kroachdb remove unneeded pass
hsheth2
approved these changes
Apr 9, 2024
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for cockroachdb ingestion based on postgres ingestion as it postgres compatible
cockroachdb is compatible with postgres, most postgres drivers are working with it seamlessly
however sqlalchemy library is not compatible with cockroachdb so there is a need to use the dedicated library sqlalchemy-cockroachdb
Checklist