Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/tableau): support platform instance mapping based off database server hostname #10254

Merged
merged 10 commits into from
May 15, 2024

Conversation

richenc
Copy link
Contributor

@richenc richenc commented Apr 9, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Apr 9, 2024
@gabe-lyons
Copy link
Contributor

@mayurinehate can you take a look here?

Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richenc
Copy link
Contributor Author

richenc commented May 15, 2024

I'm not sure why the documentation/gh-pages step is failing. Seeing the following in the details:

/home/runner/work/datahub/datahub/docs-website/generateDocsDir.ts:28
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
  throttle: {
                                                         ^
Error: File not accounted for in sidebar: docs/managed-datahub/observe/schema-assertions.md - try adding it to docs-website/sidebars.js
    at /home/runner/work/datahub/datahub/docs-website/generateDocsDir.ts:641:13
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/datahub/datahub/docs-website/generateDocsDir.ts:28:58)
error Command failed with exit code 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

> Task :docs-website:yarnGenerate FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':docs-website:yarnGenerate'.
> Process 'command '/home/runner/work/datahub/datahub/docs-website/.gradle/yarn/yarn-v1.22.1/bin/yarn'' finished with non-zero exit value 1

@gabe-lyons
Copy link
Contributor

looks like that file was introduced recently, https://github.com/datahub-project/datahub/pull/10473/files. I updated your branch to see if that addresses it.

@gabe-lyons gabe-lyons merged commit 8e5f17b into datahub-project:master May 15, 2024
58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
…abase server hostname (datahub-project#10254)

Co-authored-by: Richie Chen <richie.chen@hulu.com>
Co-authored-by: Gabe Lyons <itsgabelyons@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants