-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/tableau): support platform instance mapping based off database server hostname #10254
Conversation
…abase server hostname
@mayurinehate can you take a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure why the documentation/gh-pages step is failing. Seeing the following in the details:
|
looks like that file was introduced recently, https://github.com/datahub-project/datahub/pull/10473/files. I updated your branch to see if that addresses it. |
…abase server hostname (datahub-project#10254) Co-authored-by: Richie Chen <richie.chen@hulu.com> Co-authored-by: Gabe Lyons <itsgabelyons@gmail.com>
Checklist