Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/mode): Mode improvements: #10273

Merged
merged 4 commits into from
Apr 12, 2024
Merged

feat(ingest/mode): Mode improvements: #10273

merged 4 commits into from
Apr 12, 2024

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Apr 11, 2024 •
edited
Loading

  • column level lineage
  • external links
  • stateful ingestion support
  • owner tags
  • etc ...

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
Mode improvements:
1a35b41 
- column level lineage
- external links
- stateful ingestion support
- owner tags
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 11, 2024
hsheth2
hsheth2 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Eventually it'd be better to separate out the API interface / API client from the main source, but that can be done later

metadata-ingestion/tests/integration/mode/test_mode.py
@@ -12,6 +12,7 @@
FROZEN_TIME = "2021-12-07 07:00:00"

JSON_RESPONSE_MAP = {
"https://app.mode.com/api/verify": "verify.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it seems like it never was part of the test resources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it in the meantime :)

metadata-ingestion/src/datahub/ingestion/source/mode.py Outdated
)

operation = OperationClass(
operationType="UPDATE",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the model's enum here?

metadata-ingestion/src/datahub/ingestion/source/mode.py
entityType="query",
changeType=ChangeTypeClass.UPSERT,
entityUrn=query_instance_urn,
aspectName="queryProperties",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only entityUrn and aspect are required - everything else can be inferred automatically

@treff7es treff7es merged commit 8ed87d6 into datahub-project:master Apr 12, 2024
57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@treff7es @sleeperdeep
feat(ingest/mode): Mode improvements (datahub-project#10273)
e59dc70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @hsheth2