Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oidc settings): use correct path for preferredJwsAlgorithm #10302

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix(oidc settings): use correct path for preferredJwsAlgorithm #10302

merged 1 commit into from
Apr 16, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented Apr 16, 2024

The response from the auth/getSsoSettings endpoint uses the preferredJwsAlgorithm path.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Apr 16, 2024
@darnaut darnaut merged commit 15d0a0c into datahub-project:master Apr 16, 2024
34 of 35 checks passed
@darnaut darnaut deleted the darnaut-fix-dynamic-preferred-jws-algorithm branch April 16, 2024 20:45
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@darnaut @sleeperdeep
fix(oidc settings): use correct path for preferredJwsAlgorithm (datah…
60672c6 
…ub-project#10302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darnaut @RyanHolstien