fix(ui): show external url also in entity profile of containers #10390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
Masterchen09
force-pushed
the
fix-container-external-url
branch
from
0c7adbe
to
1bf48f6
Compare
Masterchen09
force-pushed
the
fix-container-external-url
branch
from
1bf48f6
to
bde1a2d
Compare
hsheth2
approved these changes
Jun 15, 2024
hsheth2
added
the
merge-pending-ci
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
aviv-julienjehannet
pushed a commit
to aviv-julienjehannet/datahub
that referenced
this pull request
Jul 17, 2024
…hub-project#10390) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I though my PR from last year (#8834) has fixed this issue, but maybe I also forgot to include the container.graphql in the old PR, I don't remember anymore - unless the externalUrl is included in the response by the GraphQL API, no link will be shown in the entity's profile.
Checklist