Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add actorUrn for ingestion through UI #10447

Merged
merged 1 commit into from
May 8, 2024
Merged

feat(ingest): add actorUrn for ingestion through UI #10447

merged 1 commit into from
May 8, 2024

Conversation

anshbansal
Copy link
Collaborator

actor urn not present initially
image

actor Urn after the change is done and manual execution is done
image

after change manual run
image

after change scheduled run
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 7, 2024
pedro93
pedro93 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a test for this new behaviour?

@anshbansal anshbansal added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label May 7, 2024
@anshbansal anshbansal merged commit de5b503 into master May 8, 2024
86 of 92 checks passed
@anshbansal anshbansal deleted the ab-add-audit-ingestion-actorurn branch May 8, 2024 08:26
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@anshbansal @sleeperdeep
feat(ingest): add actorUrn for ingestion through UI (datahub-project#…
f769962 
…10447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @pedro93