Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structured-properties): immutable flag #10461

Merged
merged 4 commits into from
May 9, 2024

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Comment on lines +657 to +667
public static final ResourcePrivileges STRUCTURED_PROPERTIES_PRIVILEGES =
ResourcePrivileges.of(
"structuredProperty",
"Structured Properties",
"Structured Properties",
ImmutableList.of(
CREATE_ENTITY_PRIVILEGE,
VIEW_ENTITY_PAGE_PRIVILEGE,
EXISTS_ENTITY_PRIVILEGE,
EDIT_ENTITY_PRIVILEGE,
DELETE_ENTITY_PRIVILEGE));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@david-leifker
Copy link
Collaborator Author

Nested domains is failing on master and airflow error not related to changes here.

@david-leifker david-leifker merged commit e7c7015 into master May 9, 2024
63 of 65 checks passed
@david-leifker david-leifker deleted the immutable-structured-property-1 branch May 9, 2024 18:55
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Co-authored-by: Chris Collins <chriscollins3456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants