Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap non-required $ref properties in an object to mark as nullable #10514

Merged
merged 1 commit into from
May 16, 2024
Merged

Wrap non-required $ref properties in an object to mark as nullable #10514

merged 1 commit into from
May 16, 2024

Conversation

timothyjin
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 15, 2024
@david-leifker
Copy link
Collaborator

LGTM, thanks for the update to the test!

@david-leifker david-leifker merged commit ec8e337 into datahub-project:master May 16, 2024
8 of 9 checks passed
timothyjin added a commit to timothyjin/datahub that referenced this pull request May 16, 2024
@timothyjin
Fix formatting for datahub-project#10514
d106d38
david-leifker pushed a commit that referenced this pull request May 16, 2024
@timothyjin
Fix formatting for #10514 (#10525)
ad41d20
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@timothyjin @sleeperdeep
Wrap non-required $ref properties in an object to mark as nullable (d…
a588e4d 
…atahub-project#10514)

Co-authored-by: tjin <tjin@netflix.com>
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@timothyjin @sleeperdeep
Fix formatting for datahub-project#10514 (datahub-project#10525)
e3b209d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@kevin1chun kevin1chun kevin1chun approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyjin @david-leifker @kevin1chun