Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fix bug in incremental lineage #10515

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(ingest): fix bug in incremental lineage #10515

merged 1 commit into from
May 16, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 16, 2024 •
edited
Loading

Fixes a bug introduced by #10090

This bug would cause all non-lineage aspects to disappear when incremental_lineage was enabled. Incremental lineage should be considered broken for all versions after v0.13.1.3rc2 that don't include this fix.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 16, 2024
@hsheth2 hsheth2 force-pushed the fix-incremental-lineage-helper branch from 1078713 to 34d7f24 Compare May 16, 2024 03:08
asikowitz
asikowitz approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't give a super in depth look but seems reasonable to me

@hsheth2 hsheth2 merged commit bc9250c into master May 16, 2024
58 checks passed
@hsheth2 hsheth2 deleted the fix-incremental-lineage-helper branch May 16, 2024 05:30
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@hsheth2 @sleeperdeep
fix(ingest): fix bug in incremental lineage (datahub-project#10515)
9c6af83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz