Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(neo4j): neo4j pagination as per v2 scrollApi for related entities #10537

Merged
merged 1 commit into from
May 19, 2024
Merged

feat(neo4j): neo4j pagination as per v2 scrollApi for related entities #10537

merged 1 commit into from
May 19, 2024

Conversation

deepgarg-visa
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels May 18, 2024
@deepgarg-visa deepgarg-visa force-pushed the business-attributes-neo4j-pagination branch from 1248b4d to a992947 Compare May 18, 2024 16:12
david-leifker
david-leifker reviewed May 19, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@david-leifker david-leifker added this to the v0.13.3 milestone May 19, 2024
@david-leifker david-leifker merged commit a44a549 into datahub-project:master May 19, 2024
40 of 41 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@deepgarg-visa @sleeperdeep
feat(neo4j): neo4j pagination as per v2 scrollApi for related entities (
b40d533 
datahub-project#10537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker left review comments

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
v0.13.3
Development

Successfully merging this pull request may close these issues.
2 participants
@deepgarg-visa @david-leifker