fix(ingest/dbt): resolve more dbt ephemeral node lineage gaps #10553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a refactor. The main change is also lowercasing the fake ephemeral names.
github-actions
bot
added
the
ingestion
treff7es
approved these changes
May 21, 2024
| @@ -1212,6 +1192,56 @@ def _infer_schemas_and_update_cll( # noqa: C901 | |||
| if inferred_schema_fields: | |||
| node.columns_setdefault(inferred_schema_fields) | |||
|
|
|||
| def _parse_cll( | |||
There was a problem hiding this comment.
thanks for moving this part out from the looooong method
hsheth2
changed the title
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
5 tasks
MatMoore
added a commit
to ministryofjustice/data-catalogue
that referenced
this pull request
Jul 23, 2024
A couple of fixes have gone into Datahub that I think may resolve the recursion errors. - datahub-project/datahub#10553 went into 0.13.3 - datahub-project/datahub#10678 went into 0.13.3.4 I'd like to retest this on 0.13.3.4 to see if this is the case. If not, then we can report the stack trace to Datahub.
hjribeiro-moj
pushed a commit
to ministryofjustice/data-catalogue
that referenced
this pull request
Jan 21, 2025
A couple of fixes have gone into Datahub that I think may resolve the recursion errors. - datahub-project/datahub#10553 went into 0.13.3 - datahub-project/datahub#10678 went into 0.13.3.4 I'd like to retest this on 0.13.3.4 to see if this is the case. If not, then we can report the stack trace to Datahub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a refactor. The main change is lowercasing the fake ephemeral names and fixing a minor bug in the lineage generator.
Checklist