fix(mae-consumer): fix UpdateIndicesHook ignoring events with forceIndexing property set to true #10586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
community-contribution
…dexing property set to true
Masterchen09
force-pushed
the
fix-restore-indices-update-indices-hook
branch
from
a58f742
to
388d796
Compare
aabharti-visa
pushed a commit
to aabharti-visa/datahub
that referenced
this pull request
May 30, 2024
…dexing property set to true (datahub-project#10586)
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…dexing property set to true (datahub-project#10586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the forceIndexing property is set to true, the UpdateIndicesHook should never ignore an event...the current logic is causing missing entities in the search index when using the restore indices job...
See here on Slack for details: https://datahubspace.slack.com/archives/C029A3M079U/p1716563376088529?thread_ts=1715145976.054479&cid=C029A3M079U
Checklist