Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(views): Add relationship annotation to GlobalViewsSettings urn #10597

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented May 27, 2024

Adds relationship annotation to GlobalViewsSettings's defaultView property & executes referential delete in ViewService.

This is to delete by reference modification when deleting Views that were assigned as the default.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

pedro93 and others added 2 commits May 27, 2024 17:22
Adds relationship annotation to `GlobalViewsSettings`'s `defaultView` property

This is to delete by reference modification when deleting Views that were assigned as the default.
@pedro93 pedro93 merged commit 6801cca into master Jun 3, 2024
62 of 63 checks passed
@pedro93 pedro93 deleted the feature/cus-2054 branch June 3, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants