Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion/sigma): Fix multiple requests http errors #10616

Merged
merged 9 commits into from
Jun 14, 2024
Merged

fix(ingestion/sigma): Fix multiple requests http errors #10616

merged 9 commits into from
Jun 14, 2024

Conversation

shubhamjagtap639
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 30, 2024
@shubhamjagtap639 shubhamjagtap639 marked this pull request as ready for review June 13, 2024 07:40
hsheth2
hsheth2 reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good - just a few minor things

It would be nice to have some common methods for pagination instead of implementing it everywhere, but that's fine for now

metadata-ingestion/src/datahub/ingestion/source/sigma/config.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sigma/config.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sigma/sigma_api.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 merged commit 3479d07 into datahub-project:master Jun 14, 2024
57 of 58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@shubhamjagtap639 @sleeperdeep
fix(ingestion/sigma): Fix multiple requests http errors (datahub-proj…
ccebe0e 
…ect#10616)
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@shubhamjagtap639 @yoonhyejin
fix(ingestion/sigma): Fix multiple requests http errors (#10616)
45637d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamjagtap639 @hsheth2