-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/bigquery): Support for View Labels #10648
feat(ingest/bigquery): Support for View Labels #10648
Conversation
todo: add option_name = "labels" to retrieve labels in the views query in the queries.py eg.
|
57cb617
to
9599a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style comments. Otherwise LGTM although would like a second look on the SQL query
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery.py
Outdated
Show resolved
Hide resolved
# Find all matches in the labels string | ||
matches = re.findall(pattern, labels_str) | ||
|
||
labels_dict = {key: value for key, value in matches} | ||
return labels_dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Find all matches in the labels string | |
matches = re.findall(pattern, labels_str) | |
labels_dict = {key: value for key, value in matches} | |
return labels_dict | |
# Map ?? to ?? | |
return dict(re.findall(pattern, labels_str)) |
I don't actually know what the keys and values of the returned dict represent. Let's document that somewhere
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
@hsheth2 can you take a look? |
Harshal took a look and gave the go ahead. https://acryldata.slack.com/archives/C02ENS87APK/p1718410928205629?thread_ts=1718392351.832049&cid=C02ENS87APK |
Airflow problem is separate |
Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
Checklist