feat(ingest/snowflake): refactor + parallel schema extraction #10653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
force-pushed
the
snowflake-refactor
branch
from
6498f5c
to
08777f0
Compare
treff7es
approved these changes
Jun 12, 2024
| @@ -34,6 +36,10 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| DEFAULT_REST_SINK_MAX_THREADS = int( | |||
| os.getenv("DATAHUB_REST_SINK_DEFAULT_MAX_THREADS", 15) | |||
There was a problem hiding this comment.
Shouldn't this be set based on the number of cores?
There was a problem hiding this comment.
Because of the python GIL, python pretty much runs on a single core regardless - the total number of cores available only matters when using multiprocessing, not threading.
The threads help because the rest sink is usually bound by I/O, which releases the GIL and allows other threads to run
hsheth2
force-pushed
the
snowflake-refactor
branch
from
6b50414
to
803e642
Compare
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #10642Checklist