Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): make query formatting more robust #10678

Merged
merged 1 commit into from
Jun 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata-ingestion/src/datahub/sql_parsing/sqlglot_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,8 @@ def try_format_query(

try:
dialect = get_dialect(platform)
expression = parse_statement(expression, dialect=dialect)
return expression.sql(dialect=dialect, pretty=True)
parsed_expression = parse_statement(expression, dialect=dialect)
return parsed_expression.sql(dialect=dialect, pretty=True)
except Exception as e:
if raises:
raise
Expand Down
Loading